Conversation
Introduces `prepareMigration.ts` to revoke BatchRegistrar's seeding roles on the .eth PermissionedRegistry and grant registration roles to ETHRegistrar and the Unlocked/Locked migration controllers. Extracts shared viem client/artifact helpers into `scriptUtils.ts` and refactors `preMigration.ts` to consume them. Adds e2e coverage plus a test helper that reverts the devnet into a true pre-prepareMigration state.
Add contracts/docs/prepareMigration.md covering the script's role changes, prerequisites, CLI flags, workflow, and dry-run/execute examples. Link both the pre-migration and prepare-migration docs from the contracts README Migration Controllers section.
…HRegistrar Fully decommissions BatchRegistrar by also revoking ROLE_RENEW and ROLE_RENEW_ADMIN, and grants ROLE_RENEW to ETHRegistrar so renewals flow through the live registrar after hand-off. Updates docs and e2e tests to reflect the new post-state where BatchRegistrar holds no roles.
…be-run-after-all-pre-migrations
🛡️ Immunefi PR ReviewsWe noticed that your project isn't set up for automatic code reviews. If you'd like this PR reviewed by the Immunefi team, you can request it manually using the link below: Once submitted, we'll take care of assigning a reviewer and follow up here. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44bcb025e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…onstants Replace locally-defined ROLE_* bigint literals with ROLES and DEPLOYMENT_ROLES from deploy-constants. Add ETH_REGISTRAR_ROOT to DEPLOYMENT_ROLES and use it in 03_ETHRegistrar and 04_BatchRegistrar deploy scripts. Document ROLE_RENEW_ADMIN in the signer prerequisites.
Arachnid
approved these changes
Apr 22, 2026
…be-run-after-all-pre-migrations
adraffy
approved these changes
Apr 23, 2026
hiddentao
deleted the
feature/bet-593-prepare-migration-script-to-be-run-after-all-pre-migrations
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces
prepareMigration.tsto revoke BatchRegistrar's seeding roles on the .eth PermissionedRegistry and grant registration roles to ETHRegistrar and the Unlocked/Locked migration controllers. Extracts shared viem client/artifact helpers intoscriptUtils.tsand refactorspreMigration.tsto consume them. Adds e2e coverage plus a test helper that reverts the devnet into a true pre-prepareMigration state.